linux-kernel - Re: [PATCH] staging: wavelan: fix coding style of first 1000 lines in wavelan.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100308160250.GC19256@bicker>
Date:	Mon, 8 Mar 2010 19:02:50 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Jason Dreisbach <jtdreisb@...il.com>
Cc:	jt@....hp.com, gregkh@...e.de--to, jpirko@...hat.com,
	linville@...driver.com, jtdreisb@...il.com--cc,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] staging: wavelan: fix coding style of first 1000 lines
	in wavelan.c

On Mon, Mar 08, 2010 at 02:20:30AM -0800, Jason Dreisbach wrote:
> From: Jason <jtdreisb@...il.com>

>  		/* Check mc_config command */
>  		if ((status & AC_SFLD_OK) != AC_SFLD_OK)
>  			printk(KERN_INFO
> -			       "%s: wv_config_complete(): set_multicast_address failed; status = 0x%x\n",
> +			       "%s: wv_config_complete(): \
> +			       set_multicast_address failed; status = 0x%x\n",
>  			       dev->name, status);
>  

This patch introduces several bugs like the one above.

I know it's depressing to send a patch and have criticized, but besides
this bug which affects users there are some other whitespace changes 
in this patch which are not correct.

If you want to resend this once you fix the errors, feel free, it does 
fix quite a few white space issues.  

But really it's always better to focus on fixing actual bugs.  I know that
Greg says fixing white space is a great way to learn the patch submission
process, but anyone can do that.  The most important thing is to learn how
to fix bugs.  We can deal with malformed patches so long as they fix 
something.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/