linux-kernel - Re: [Bug #14943] nfs regression?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100308202110.GA4731@nik-comp.linuxbox.cz>
Date:	Mon, 8 Mar 2010 21:21:10 +0100
From:	Nikola Ciprich <extmaillist@...uxbox.cz>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Maciej Rutecki <maciej.rutecki@...il.com>,
	nikola.ciprich@...uxbox.cz
Subject: Re: [Bug #14943] nfs regression?

YES!
seems like 2.6.32.8 with your patch included finally doesn't
spit any backtraces and peername failed errors!
will You push this upstream + to stable?
thanks a lot for Your help!
have a nice day
with best regards
nik

> This seems that we missed checking XPT_DEAD too.
> 
> Nikola, does adding !test_bit(XPT_DEAD, &xprt->xpt_flags) in the same
> place as commit b292cf9ce70d221c3f04f help?
> 
> Something like:
> 
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index 7d1f9e9..7b66c7f 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -700,7 +700,8 @@ int svc_recv(struct svc_rqst *rqstp, long timeout)
> 
>         len = 0;
>         if (test_bit(XPT_LISTENER, &xprt->xpt_flags) &&
> -           !test_bit(XPT_CLOSE, &xprt->xpt_flags)) {
> +           !test_bit(XPT_CLOSE, &xprt->xpt_flags) &&
> +           !test_bit(XPT_DEAD, &xprt->xpt_flags)) {
>                 struct svc_xprt *newxpt;
>                 newxpt = xprt->xpt_ops->xpo_accept(xprt);
>                 if (newxpt) {
> 

-- 
-------------------------------------
Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799

www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@...uxbox.cz
-------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/