linux-kernel - Re: [PATCH] Kernel: Fix coding style in kernel/audit.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100308204359.GN30031@ZenIV.linux.org.uk>
Date:	Mon, 8 Mar 2010 20:44:00 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	wzt.wzt@...il.com
Cc:	linux-kernel@...r.kernel.org, linux-audit@...hat.com,
	eparis@...hat.com, faith@...hat.com
Subject: Re: [PATCH] Kernel: Fix coding style in kernel/audit.c

On Tue, Mar 09, 2010 at 06:27:42AM +0800, wzt.wzt@...il.com wrote:
> Fix coding style in kernel/audit.c
> 
> Signed-off-by: Zhitong Wang <zhitong.wangzt@...baba-inc.com>

NACKed-by: Al Viro <viro@...iv.linux.org.uk>
NACKed-because: get a life

>  static int audit_set_enabled(int state, uid_t loginuid, u32 sessionid, u32 sid)
>  {
>  	int rc;
> +
>  	if (state < AUDIT_OFF || state > AUDIT_LOCKED)
>  		return -EINVAL;
>  
>  	rc =  audit_do_config_change("audit_enabled", &audit_enabled, state,
>  				     loginuid, sessionid, sid);
> -
>  	if (!rc)
>  		audit_ever_enabled |= !!state;

Seriously, people, please stop that masturbation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/