[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.00.1003081324550.14689@chino.kir.corp.google.com>
Date: Mon, 8 Mar 2010 13:27:11 -0800 (PST)
From: David Rientjes <rientjes@...gle.com>
To: Miao Xie <miaox@...fujitsu.com>
cc: Nick Piggin <npiggin@...e.de>,
Lee Schermerhorn <lee.schermerhorn@...com>,
Paul Menage <menage@...gle.com>,
Linux-Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 3/4] cpuset: alloc nodemask_t at heap not stack
On Mon, 8 Mar 2010, Miao Xie wrote:
> Changes from V1 to V2:
> - None
>
Both this and patch 2/4 are already in -mm, so please rebase this series
on mmotm-2010-03-04-18-05.
> @@ -1381,39 +1394,46 @@ static void cpuset_attach(struct cgroup_subsys *ss, struct cgroup *cont,
> struct cgroup *oldcont, struct task_struct *tsk,
> bool threadgroup)
> {
> - nodemask_t from, to;
> struct mm_struct *mm;
> struct cpuset *cs = cgroup_cs(cont);
> struct cpuset *oldcs = cgroup_cs(oldcont);
> + NODEMASK_ALLOC(nodemask_t, from, GFP_KERNEL);
> + NODEMASK_ALLOC(nodemask_t, to, GFP_KERNEL);
> +
> + if (from == NULL || to == NULL)
> + return;
>
You're potentially leaking one of the allocated nodemasks there if the
other is -ENOMEM.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists