linux-kernel - Re: [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <AC7EBCFD-B650-4B58-B12A-13D20F56E7FF@enac.fr>
Date:	Tue, 9 Mar 2010 16:43:08 +0100
From:	Stéphane Chatty <chatty@...c.fr>
To:	Rafi Rubin <rafi@...s.upenn.edu>
Cc:	mickib1@...il.com, Jiri Kosina <jkosina@...e.cz>,
	peterhuewe@....de, Micki Balanga <micki@...rig.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] HID: N-trig MTM Driver fix and cleanup patch 2


Le 9 mars 10 à 02:07, Rafi Rubin a écrit :
>
>>   		case HID_DG_HEIGHT:
>>   			hid_map_usage(hi, usage, bit, max,
>>   					EV_ABS, ABS_MT_TOUCH_MINOR);
>> -			input_set_abs_params(hi->input, ABS_MT_ORIENTATION,
>> -					0, 1, 0, 0);
>
> Stephane added the orientation to height, I can't comment about the  
> wisdom of pulling it.

The MT kernel protocol says that width/height is reported through  
TouchMinor/TouchMajor/Orientation. Orientation needs to be added  
somewhere. Doing it when encountering width or height seemed a  
logical thing to do, but I would see no objection at doing it  
somewhere else with TouchMinor and TouchMajor.

Cheers,

St.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/