linux-kernel - Re: [PATCH 6/7] HID: N-trig MTM Driver fix And cleanup patch 6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B95A24D.2090903@seas.upenn.edu>
Date:	Mon, 08 Mar 2010 20:20:13 -0500
From:	Rafi Rubin <rafi@...s.upenn.edu>
To:	mickib1@...il.com
CC:	jkosina@...e.cz, chatty@...c.fr, peterhuewe@....de,
	micki@...rig.com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, rafi@...s.upenn.edu
Subject: Re: [PATCH 6/7] HID: N-trig MTM Driver fix And cleanup patch 6

>   static const struct hid_device_id ntrig_devices[] = {
>   	{ HID_USB_DEVICE(USB_VENDOR_ID_NTRIG, USB_DEVICE_ID_NTRIG_TOUCH_SCREEN),
> -		.driver_data = NTRIG_DUPLICATE_USAGES },
> +		.driver_data = NTRIG_USB_DEVICE_ID },

The vendor and device id are in the first field "HID_USB_DEVICE", driver 
data is for flags, not id.  Its merely a coincidence that they are the 
same in this case.

The duplicate usages tells hid to let you have more than one "x" and "y" 
axis.  Otherwise each finger gets a new set (the second finger gets "z" 
and "rx" and so on).

>   static int __init ntrig_init(void)
>   {
> +	info("N-trig Driver Version 1.6\n");

Perhaps you mean:
MODULE_VERSION("1.06");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/