linux-kernel - Re: [PATCH] x86, k8 nb: Enable k8_northbridges unconditionally on AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100309103124T.fujita.tomonori@lab.ntt.co.jp>
Date:	Tue, 9 Mar 2010 10:32:01 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	bp@...64.org
Cc:	mingo@...e.hu, hpa@...or.com, tglx@...utronix.de,
	fujita.tomonori@....ntt.co.jp, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, k8 nb: Enable k8_northbridges unconditionally on
 AMD

On Mon, 8 Mar 2010 18:06:37 +0100
Borislav Petkov <bp@...64.org> wrote:

> From: Borislav Petkov <borislav.petkov@....com>
> Date: Mon, 8 Mar 2010 14:27:01 +0100
> Subject: [PATCH] x86, k8 nb: Enable k8_northbridges unconditionally on AMD
> 
> de957628ce7c84764ff41331111036b3ae5bad0f changed setting of the
> x86_init.iommu.iommu_init function ptr only when GART IOMMU is found.
> 
> One side effect of it is that num_k8_northbridges
> is not initialized anymore if not explicitly
> called. This resulted in uninitialized pointers in
> <arch/x86/kernel/cpu/intel_cacheinfo.c:amd_calc_l3_indices()>,
> for example, which uses the num_k8_northbridges thing through
> node_to_k8_nb_misc().
> 
> Fix that through an initcall that runs right after the PCI subsystem and
> does all the scanning. Then, remove initialization in gart_iommu_init()
> which is a rootfs_initcall and we're running before that.
> 
> What is more, since num_k8_northbridges is being used in other places
> beside GART IOMMU, include it whenever we add AMD CPU support.
> 
> Signed-off-by: Borislav Petkov <borislav.petkov@....com>
> Tested-by: Joerg Roedel <joerg.roedel@....com>
> ---
>  arch/x86/Kconfig              |    2 +-
>  arch/x86/kernel/k8.c          |   14 ++++++++++++++
>  arch/x86/kernel/pci-gart_64.c |    2 +-
>  3 files changed, 16 insertions(+), 2 deletions(-)

Thanks a lot!

Looks correct to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/