[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20100309214456.GA32617@redhat.com>
Date: Tue, 9 Mar 2010 22:44:56 +0100
From: Oleg Nesterov <oleg@...hat.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Andi Kleen <andi@...stfloor.org>,
David Howells <dhowells@...hat.com>,
Neil Horman <nhorman@...driver.com>,
Rusty Russell <rusty@...tcorp.com.au>,
linux-kernel@...r.kernel.org
Subject: [PATCH -mm 1/3] call_usermodehelper: no need to unblock the signals
____call_usermodehelper() correctly calls flush_signal_handlers()
to set SIG_DFL, but sigemptyset(->blocked) and recalc_sigpending()
are not needed.
This kthread was forked by workqueue thread, all signals must be
unblocked and ignored, no pending signal is possible.
Signed-off-by: Oleg Nesterov <oleg@...hat.com>
---
kernel/kmod.c | 3 ---
1 file changed, 3 deletions(-)
--- mm/kernel/kmod.c~1_SIGNALS 2010-02-26 22:07:38.000000000 +0100
+++ mm/kernel/kmod.c 2010-03-09 21:31:09.000000000 +0100
@@ -153,11 +153,8 @@ static int ____call_usermodehelper(void
struct subprocess_info *sub_info = data;
int retval;
- /* Unblock all signals */
spin_lock_irq(¤t->sighand->siglock);
flush_signal_handlers(current, 1);
- sigemptyset(¤t->blocked);
- recalc_sigpending();
spin_unlock_irq(¤t->sighand->siglock);
/* We can run anywhere, unlike our parent keventd(). */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists