| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Mar 2010 15:41:52 -0800 From: Greg KH <gregkh@...e.de> To: Joe Perches <joe@...ches.com> Cc: LKML <linux-kernel@...r.kernel.org>, devel <devel@...verdev.osuosl.org>, Andy Whitcroft <apw@...dowen.org> Subject: Re: Tuxradar patching article and [PATCH] scripts/cvt_kernel_style.pl On Tue, Mar 09, 2010 at 03:32:06PM -0800, Joe Perches wrote: > There was an article published recently: > http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel > that seems to have prompted several new contributors (welcome) > to create style reformatting patches. > > The article recommends running checkpatch and fixing the various > non-conforming style elements the output produces. > > A better solution might be to enhance checkpatch to rewrite the > patch or a file with -f, but that's more than I'd like to do. I _really_ dislike automatic source conversions by a tool and do not recommend doing that at all. It's better that you look at the code yourself, and make the change that looks correct, which is not always the same thing that an automated tool would do. Becides, we have the Lindent script, which does almost exactly what you are trying to do here, why reinvent the wheel? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists