linux-kernel - Re: [PATCH] coredump: plug a memory leak situation on dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100309120706.7CD2.A69D9226@jp.fujitsu.com>
Date:	Tue,  9 Mar 2010 12:08:46 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Andre Goddard Rosa <andre.goddard@...il.com>
Cc:	kosaki.motohiro@...fujitsu.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Roland McGrath <roland@...hat.com>,
	WANG Cong <amwang@...hat.com>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coredump: plug a memory leak situation on dump_seek()

> After having started writing the coredump, if filesystem reports an error
> anytime while writing part of the core file, we would leak a memory page
> when bailing out.
> 
> Signed-off-by: André Goddard Rosa <andre.goddard@...il.com>
> Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>

Looks good.
Thanks, Andre!

  - kosaki

> ---
>  include/linux/coredump.h |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/coredump.h b/include/linux/coredump.h
> index b3c91d7..8ba66a9 100644
> --- a/include/linux/coredump.h
> +++ b/include/linux/coredump.h
> @@ -16,6 +16,8 @@ static inline int dump_write(struct file *file, const void *addr, int nr)
>  
>  static inline int dump_seek(struct file *file, loff_t off)
>  {
> +	int ret = 1;
> +
>  	if (file->f_op->llseek && file->f_op->llseek != no_llseek) {
>  		if (file->f_op->llseek(file, off, SEEK_CUR) < 0)
>  			return 0;
> @@ -29,13 +31,15 @@ static inline int dump_seek(struct file *file, loff_t off)
>  
>  			if (n > PAGE_SIZE)
>  				n = PAGE_SIZE;
> -			if (!dump_write(file, buf, n))
> -				return 0;
> +			if (!dump_write(file, buf, n)) {
> +				ret = 0;
> +				break;
> +			}
>  			off -= n;
>  		}
>  		free_page((unsigned long)buf);
>  	}
> -	return 1;
> +	return ret;
>  }
>  
>  #endif /* _LINUX_COREDUMP_H */
> -- 
> 1.7.0.1.164.gbe2f
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/