linux-kernel - Re: [PATCH] freezer: only show the state of tasks refusing to freeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100310094337.GA19370@atrey.karlin.mff.cuni.cz>
Date:	Wed, 10 Mar 2010 10:43:37 +0100
From:	Pavel Machek <pavel@....cz>
To:	Xiaotian Feng <dfeng@...hat.com>
Cc:	linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...k.pl>, Len Brown <len.brown@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH] freezer: only show the state of tasks refusing to
	freeze

> show_state will dump all tasks state, so if freezer failed to freeze
> any task, kernel will dump all tasks state and flood the dmesg log.
> This patch makes freezer only show state of tasks refusing to freeze.
> 
> Signed-off-by: Xiaotian Feng <dfeng@...hat.com>
> Cc: Pavel Machek <pavel@....cz>

ACK.

> diff --git a/kernel/power/process.c b/kernel/power/process.c
> index 5ade1bd..a0480cd 100644
> --- a/kernel/power/process.c
> +++ b/kernel/power/process.c
> @@ -88,12 +88,11 @@ static int try_to_freeze_tasks(bool sig_only)
>  		printk(KERN_ERR "Freezing of tasks failed after %d.%02d seconds "
>  				"(%d tasks refusing to freeze):\n",
>  				elapsed_csecs / 100, elapsed_csecs % 100, todo);
> -		show_state();
>  		read_lock(&tasklist_lock);
>  		do_each_thread(g, p) {
>  			task_lock(p);
>  			if (freezing(p) && !freezer_should_skip(p))
> -				printk(KERN_ERR " %s\n", p->comm);
> +				sched_show_task(p);
>  			cancel_freezing(p);
>  			task_unlock(p);
>  		} while_each_thread(g, p);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/