linux-kernel - Re: [PATCH 02/19] crypto: khazad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100310102723.GB23298@gondor.apana.org.au>
Date:	Wed, 10 Mar 2010 18:27:23 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Richard Hartmann <richih.mailinglist@...il.com>
Cc:	linux-crypto@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/19] crypto: khazad - Fix checkpatch errors

On Fri, Feb 19, 2010 at 01:21:41AM +0100, Richard Hartmann wrote:
> 
> Signed-off-by: Richard Hartmann <richih.mailinglist@...il.com>
> ---
>  crypto/khazad.c |   71 +++++++++++++++++++++++++++----------------------------
>  1 files changed, 35 insertions(+), 36 deletions(-)
>
> @@ -810,25 +810,25 @@ static void khazad_crypt(const u64 roundKey[KHAZAD_ROUNDS + 1],
>  	state = be64_to_cpu(*src) ^ roundKey[0];
>  
>  	for (r = 1; r < KHAZAD_ROUNDS; r++) {
> -		state = T0[(int)(state >> 56)       ] ^
> -			T1[(int)(state >> 48) & 0xff] ^
> -			T2[(int)(state >> 40) & 0xff] ^
> -			T3[(int)(state >> 32) & 0xff] ^
> -			T4[(int)(state >> 24) & 0xff] ^
> -			T5[(int)(state >> 16) & 0xff] ^
> -			T6[(int)(state >>  8) & 0xff] ^
> -			T7[(int)(state      ) & 0xff] ^
> +		state = T0[(int)(state >> 56)] ^
> +			T1[(int)(state >> 48)&0xff] ^
> +			T2[(int)(state >> 40)&0xff] ^
> +			T3[(int)(state >> 32)&0xff] ^
> +			T4[(int)(state >> 24)&0xff] ^
> +			T5[(int)(state >> 16)&0xff] ^
> +			T6[(int)(state >>  8)&0xff] ^
> +			T7[(int)(state      )&0xff] ^
>  			roundKey[r];
> -    	}
> +		}

This indentation change is bogus.

> @@ -865,7 +865,6 @@ static struct crypto_alg khazad_alg = {
>  static int __init khazad_mod_init(void)
>  {
>  	int ret = 0;
> -	
>  	ret = crypto_register_alg(&khazad_alg);
>  	return ret;
>  }

What's this for?

Please review the all the rest of the patches for similar errors
and resubmit.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/