linux-kernel - Re: Tuxradar patching article and [PATCH] scripts/cvt_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1268181257.1545.107.camel@Joe-Laptop.home>
Date:	Tue, 09 Mar 2010 16:34:17 -0800
From:	Joe Perches <joe@...ches.com>
To:	Greg KH <gregkh@...e.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	devel <devel@...verdev.osuosl.org>,
	Andy Whitcroft <apw@...dowen.org>
Subject: Re: Tuxradar patching article and [PATCH]
 scripts/cvt_kernel_style.pl

On Tue, 2010-03-09 at 15:41 -0800, Greg KH wrote:
> I _really_ dislike automatic source conversions by a tool and do not
> recommend doing that at all.
 
On Tue, 2010-03-09 at 16:16 -0800, Greg KH wrote:
> > You take automatic conversions from tools like coccinelle all
> > the time.
> Those are sane, as they are tiny and obvious :)

You contradict yourself.

> It's the huge "reformat the whole file with indent" type stuff
> that I object to.

Which is sensible and not what you lead with.

Any conversion done an automatic tool should be limited to
a specific type of change and should not be done wholesale.

Scripts like what I posted are easy to limit to specific
types of conversion.  Tools like Lindent are not.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/