linux-kernel - [PATCH]: cleanup debug message in init_kstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 10 Mar 2010 09:05:35 -0500
From:	Prarit Bhargava <prarit@...hat.com>
To:	linux-kernel@...r.kernel.org, yinghai@...nel.org
Cc:	Prarit Bhargava <prarit@...hat.com>
Subject: [PATCH]: cleanup debug message in init_kstat_irqs()

Cleanup a debug message in init_kstat_irqs().

This debug message can result in valid output like

	alloc kstat_irqs on node -1

which looks alot like an error message.

This debug statement has been in the kernel for over a year, so I think it is
safe to remove it and report the node in only the error case instead.

Signed-off-by: Prarit Bhargava <prarit@...hat.com>

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 76d5a67..e7fb871 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -94,10 +94,10 @@ void __ref init_kstat_irqs(struct irq_desc *desc, int node, int nr)
 	 * don't overwite if can not get new one
 	 * init_copy_kstat_irqs() could still use old one
 	 */
-	if (ptr) {
-		printk(KERN_DEBUG "  alloc kstat_irqs on node %d\n", node);
+	if (ptr)
 		desc->kstat_irqs = ptr;
-	}
+	else
+		printk(KERN_ERR "  alloc kstat_irqs on node %d failed\n", node);
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/