lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4B97BCEA.1000101@redhat.com>
Date:	Wed, 10 Mar 2010 10:38:18 -0500
From:	Jarod Wilson <jarod@...hat.com>
To:	Tomas Dabasinskas <tomas.it@...il.com>
CC:	gregkh@...e.de, abraham.manu@...il.com, davilla@....com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: crystalhd: fixed white spaces and brace coding
 in crystalhd_hw.c

On 03/10/2010 04:51 AM, Tomas Dabasinskas wrote:

 > This is a patch to the crystalhd_hw.c file that fixes up a white
 > space and brace warnings found by the checkpatch.pl tool
 >
 > Signed-off-by: Tomas Dabasinskas <tomas.it@...il.com>

Acked-by: Jarod Wilson <jarod@...hat.com>

Although, ultimately, I'm planning to replace all the BCMLOG bits anyway 
with dev_foo printk wrappers. Just haven't had time to yet.

--jarod


> ---
>   drivers/staging/crystalhd/crystalhd_hw.c |   29 ++++++++++++-----------------
>   1 files changed, 12 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c
> index 01819d3..772da05 100644
> --- a/drivers/staging/crystalhd/crystalhd_hw.c
> +++ b/drivers/staging/crystalhd/crystalhd_hw.c
> @@ -431,7 +431,7 @@ static void crystalhd_hw_delete_ioqs(struct crystalhd_hw *hw)
>   	if (!hw)
>   		return;
>
> -	BCMLOG(BCMLOG_DBG, "Deleting IOQs \n");
> +	BCMLOG(BCMLOG_DBG, "Deleting IOQs\n");
>   	crystalhd_hw_delete_ioq(hw->adp, hw->tx_actq);
>   	crystalhd_hw_delete_ioq(hw->adp, hw->tx_freeq);
>   	crystalhd_hw_delete_ioq(hw->adp, hw->rx_actq);
...

-- 
Jarod Wilson
jarod@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ