linux-kernel - Re: [PATCH] x86: namespace some I/O APIC related structures and functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1d3zcksv3.fsf@fess.ebiederm.org>
Date:	Wed, 10 Mar 2010 09:07:44 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	ijc@...lion.org.uk
Cc:	linux-kernel@...r.kernel.org,
	Ian Campbell <ian.campbell@...rix.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Yinghai Lu <yinghai@...nel.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>, x86@...nel.org
Subject: Re: [PATCH] x86: namespace some I/O APIC related structures and functions.

ijc@...lion.org.uk writes:

> From: Ian Campbell <ian.campbell@...rix.com>
>
> It is not obvious that certain functions relate specifically to the
> I/O APIC. Rename structures and functions as follows:
>
>   struct irq_cfg -> struct ioapic_irq_cfg
>   irq_cfg() -> ioapic_irq_cfg()
>   assign_irq_vector() -> ioapic_assign_irq_vector()
>   send_cleanup_vector() -> ioapic_send_cleanup_vector()
>
> There is a slight preference towards ioapic vs io_apic in the current
> code (563 occurances vs 146) so I went with that.

The rename is wrong.  Only the optional irq_2_pin list in struct
irq_cfg is specific to ioapics.

The rest of the fields are all about the architectural vector based
interrupt delivery system of x86.  Branding that structure with ioapic
is strongly misleading.

x86_irq_cfg might be an appropriate rename.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/