linux-kernel - Re: ATA 4 KiB sector issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Mar 2010 17:50:57 -0300
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>
Cc:	Karel Zak <kzak@...hat.com>, Michael Tokarev <mjt@....msk.ru>,
	Mike Snitzer <snitzer@...hat.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: ATA 4 KiB sector issues.

On Wed, 10 Mar 2010, Martin K. Petersen wrote:
> >>>>> "Karel" == Karel Zak <kzak@...hat.com> writes:
> 
> [Cleaned up the CC: list from hell]
> 
> Karel>  # cat /sys/block/md8/queue/{minimum,optimal}_io_size
> Karel>  65536 65536
> 
> This one had me puzzled.  We set min_io and opt_io correctly in raid5.c
> depending on number of non-parity disks.  And yet it turns into
> something nonsensical after.
> 
> Turns out we overrun unsigned int calculating the lowest common multiple
> in the stacking function.  That's why we ended up with the wrong value.
> 
> I never noticed this because my userland topology regression test tool
> uses unsigned long.
> 
> I'll get a patch off to Jens right away.

And please get the whole fixed deal in -stable eventually, for 2.6.32.y's
benefit :-)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/