linux-kernel - Re: [patch] proc: cleanup: remove unused assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100311102951.GL6321@bicker>
Date:	Thu, 11 Mar 2010 13:29:51 +0300
From:	Dan Carpenter <error27@...il.com>
To:	"Helight.Xu" <helight.xu@...il.com>
Cc:	akpm@...ux-foundation.org, Al Viro <viro@...iv.linux.org.uk>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	James Morris <jmorris@...ei.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
	Serge Hallyn <serue@...ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [patch] proc: cleanup: remove unused assignments

On Thu, Mar 11, 2010 at 06:17:58PM +0800, Helight.Xu wrote:
> Dan Carpenter wrote:
>> I removed 3 unused assignments.  The first two get reset on the first
>> statement of their functions.  For "err" in root.c we don't return an  
>> error and we don't use the variable again.
>>
>> Signed-off-by: Dan Carpenter <error27@...il.com>
>>
>> diff --git a/fs/proc/base.c b/fs/proc/base.c
>> index a731084..875d636 100644
>> --- a/fs/proc/base.c
>> +++ b/fs/proc/base.c
>> @@ -2434,7 +2434,7 @@ static struct dentry *proc_base_instantiate(struct inode *dir,
>>  	const struct pid_entry *p = ptr;
>>  	struct inode *inode;
>>  	struct proc_inode *ei;
>> -	struct dentry *error = ERR_PTR(-EINVAL);
>> +	struct dentry *error;
>>   	/* Allocate the inode */
>>  	error = ERR_PTR(-ENOMEM);
>>   
> why not do it like this:
>
> @@ -2434,7 +2434,7 @@ static struct dentry *proc_base_instantiate(struct inode *dir,
> 	const struct pid_entry *p = ptr;
> 	struct inode *inode;
> 	struct proc_inode *ei;
> -	struct dentry *error = ERR_PTR(-EINVAL);
> +	struct dentry *error = ERR_PTR(-ENOMEM);
>
> 	/* Allocate the inode */
> -	error = ERR_PTR(-ENOMEM);
>

It's a personal preference.  If anyone read the code in initializers, I 
wouldn't have had had anything to clean up in the first place.  ;)

regards,
dan carpenter

>
>
>> @@ -2784,7 +2784,7 @@ out:
>>   struct dentry *proc_pid_lookup(struct inode *dir, struct dentry * 
>> dentry, struct nameidata *nd)
>>  {
>> -	struct dentry *result = ERR_PTR(-ENOENT);
>> +	struct dentry *result;
>>  	struct task_struct *task;
>>  	unsigned tgid;
>>  	struct pid_namespace *ns;
>> diff --git a/fs/proc/root.c b/fs/proc/root.c
>> index 757c069..4258384 100644
>> --- a/fs/proc/root.c
>> +++ b/fs/proc/root.c
>> @@ -110,7 +110,6 @@ void __init proc_root_init(void)
>>  	if (err)
>>  		return;
>>  	proc_mnt = kern_mount_data(&proc_fs_type, &init_pid_ns);
>> -	err = PTR_ERR(proc_mnt);
>>  	if (IS_ERR(proc_mnt)) {
>>  		unregister_filesystem(&proc_fs_type);
>>  		return;
>>
>>   
>
>
> -- 
> Zhenwen Xu - Seven Helight
> Home Page: http://zhwen.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/