linux-kernel - [PATCH] c2port: fix device_create() return value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1268324452-30589-1-git-send-email-ext-jani.1.nikula@nokia.com>
Date:	Thu, 11 Mar 2010 18:20:52 +0200
From:	Jani Nikula <ext-jani.1.nikula@...ia.com>
To:	linux-kernel@...r.kernel.org
Cc:	giometti@...ux.it, vegard.nossum@...il.com,
	akpm@...ux-foundation.org, ext-jani.1.nikula@...ia.com
Subject: [PATCH] c2port: fix device_create() return value check

From: Jani Nikula <ext-jani.1.nikula@...ia.com>

Use IS_ERR() instead of comparing to NULL.

Signed-off-by: Jani Nikula <ext-jani.1.nikula@...ia.com>

---

NOTE: I'm afraid I'm unable to test this; please consider this more a
bug report than a complete patch.
---
 drivers/misc/c2port/core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/c2port/core.c b/drivers/misc/c2port/core.c
index b5346b4..3276216 100644
--- a/drivers/misc/c2port/core.c
+++ b/drivers/misc/c2port/core.c
@@ -912,7 +912,7 @@ struct c2port_device *c2port_device_register(char *name,
 
 	c2dev->dev = device_create(c2port_class, NULL, 0, c2dev,
 					"c2port%d", id);
-	if (unlikely(!c2dev->dev)) {
+	if (unlikely(IS_ERR(c2dev->dev))) {
 		ret = -ENOMEM;
 		goto error_device_create;
 	}
-- 
1.6.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/