[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4B994022.6030703@msgid.tls.msk.ru>
Date: Thu, 11 Mar 2010 22:10:26 +0300
From: Michael Tokarev <mjt@....msk.ru>
To: Jeff Moyer <jmoyer@...hat.com>
CC: linux-aio@...ck.org, Linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: aio: compat_ioctl issue?
Jeff Moyer wrote:
[]
> Yeah, whoops. I built the libaio test harness using -m32 and this patch
> works for me. Would you mind giving it a try?
It appears to work here so far. I did not run massive i/o test suite
but it now passes basic multiple kernel unpacking in parallel tests
(before it didnt' even recognize the partition table).
So the patch - at least basically - works.
Except that we now have code duplication in kernel. Look at
fs/compat.c:compat_do_readv_writev() - it does the same as
compat_rw_copy_check_uvector() plus a bit more. I guess it
is a good idea to use compat_rw_copy_check_uvector() in
compat_do_readv_writev() to build the compat vectors...
Thank you for the patch and the fix!
/mjt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists