linux-kernel - Re: [PATCH] crypto: Add AES-NI accelerated CTR mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100311121510.80a16ec4.akpm@linux-foundation.org>
Date:	Thu, 11 Mar 2010 12:15:10 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Huang Ying <ying.huang@...el.com>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] crypto: Add AES-NI accelerated CTR mode

On Mon, 01 Mar 2010 14:14:36 +0800
Huang Ying <ying.huang@...el.com> wrote:

> To take advantage of the hardware pipeline implementation of AES-NI
> instructions. CTR mode cryption is implemented in ASM to schedule
> multiple AES-NI instructions one after another. This way, some latency
> of AES-NI instruction can be eliminated.
> 
> Performance testing based on dm-crypt should 50% reduction of
> ecryption/decryption time.
> 
> ...
>
> +/*
> + * _aesni_inc_init:	internal ABI
> + *	setup registers used by _aesni_inc
> + * input:
> + *	IV
> + * output:
> + *	CTR:	== IV, in little endian
> + *	TCTR_LOW: == lower qword of CTR
> + *	INC:	== 1, in little endian
> + *	BSWAP_MASK == endian swapping mask
> + */
> +_aesni_inc_init:
> +	movaps .Lbswap_mask, BSWAP_MASK
> +	movaps IV, CTR
> +	PSHUFB_XMM BSWAP_MASK CTR
> +	mov $1, TCTR_LOW
> +	movq TCTR_LOW, INC
> +	movq CTR, TCTR_LOW

^^ these two lines don't assemble with gas 2.16.1:

arch/x86/crypto/aesni-intel_asm.S: Assembler messages:
arch/x86/crypto/aesni-intel_asm.S:752: Error: suffix or operands invalid for `movq'
arch/x86/crypto/aesni-intel_asm.S:753: Error: suffix or operands invalid for `movq'

> +	ret

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/