linux-kernel - Re: [PATCH] x86/kvm: Show guest system/user cputime in cpustat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100312085321.GA9075@ub-qhe2>
Date:	Fri, 12 Mar 2010 16:53:21 +0800
From:	Qing He <qing.he@...el.com>
To:	Sheng Yang <sheng@...ux.intel.com>
Cc:	Avi Kivity <avi@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>,
	Ingo Molnar <mingo@...e.hu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: Re: [PATCH] x86/kvm: Show guest system/user cputime in cpustat

On Thu, 2010-03-11 at 17:17 +0800, Sheng Yang wrote:
> On Thursday 11 March 2010 15:50:54 Avi Kivity wrote:
> > On 03/11/2010 09:46 AM, Sheng Yang wrote:
> > > On Thursday 11 March 2010 15:36:01 Avi Kivity wrote:
> > >> On 03/11/2010 09:20 AM, Sheng Yang wrote:
> > >>> Currently we can only get the cpu_stat of whole guest as one. This
> > >>> patch enhanced cpu_stat with more detail, has guest_system and
> > >>> guest_user cpu time statistics with a little overhead.
> > >>>
> > >>> Signed-off-by: Sheng Yang<sheng@...ux.intel.com>
> > >>> ---
> > >>>
> > >>> This draft patch based on KVM upstream to show the idea. I would split
> > >>> it into more kernel friendly version later.
> > >>>
> > >>> The overhead is, the cost of get_cpl() after each exit from guest.
> > >>
> > >> This can be very expensive in the nested virtualization case, so I
> > >> wouldn't like this to be in normal paths.  I think detailed profiling
> > >> like that can be left to 'perf kvm', which only has overhead if enabled
> > >> at runtime.
> > >
> > > Yes, that's my concern too(though nested vmcs/vmcb read already too
> > > expensive, they should be optimized...).
> > 
> > Any ideas on how to do that?  Perhaps use paravirt_ops to covert the
> > vmread into a memory read?  We store the vmwrites in the vmcs anyway.
> 
> When Qing(CCed) was working on nested VMX in the past, he found PV 
> vmread/vmwrite indeed works well(it would write to the virtual vmcs so vmwrite 
> can also benefit). Though compared to old machine(one our internal patch shows 
> improve more than 5%), NHM get less benefit due to the reduced vmexit cost.
> 

One of the hurdles to PVize vmread/vmwrite is the fact that the memory
layout of physical vmcs remains unknown. Of course it can use the custom
vmcs layout utilized by nested virtualization, but that looks a little weird,
since different nested virtualization implementation may create different
custom layout.

I once used another approach to partially accelerate the vmread/vmwrite
in nested virtualization case, which also gives good performance gain (around
7% on pre-nehalem, based on this, PV vmread/vmwrite had another 7%). That
is to make a shortcut to handle EXIT_REASON_VM{READ,WRITE}, without
even turning on the IF.

Thanks,
Qing
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/