linux-kernel - Re: [PATCH] ide: Build break in ide-iops.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Mar 2010 20:17:00 +0800
From:	Wu Zhangjin <wuzhangjin@...il.com>
To:	John Kacur <jkacur@...hat.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	rt-users <linux-rt-users@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Sergei Shtylyov <sshtylyov@...mvista.com>
Subject: Re: [PATCH] ide: Build break in ide-iops.c

On Fri, 2010-03-12 at 13:10 +0100, John Kacur wrote:
> I get the following build break due to 876c52cc046e00eaa2ffc5124dc187106ef57594
> 
> drivers/ide/ide-iops.c:29:26: error: asm/bootinfo.h: No such file or directory
> 

I think we'd better revert that commit
876c52cc046e00eaa2ffc5124dc187106ef57594 for it has introduced some arch
specific parts into the common ide source code.

And that commit doesn't influence the preempt-rt support, so, Thomas,
could you please revert it directly, thanks!

Regards,
	Wu Zhangjin

> Protect the include by #ifdef CONFIG_MIPS
> 
> Signed-off-by: John Kacur <jkacur@...hat.com>
> ---
>  drivers/ide/ide-iops.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c
> index 9dba71e..8d32dda 100644
> --- a/drivers/ide/ide-iops.c
> +++ b/drivers/ide/ide-iops.c
> @@ -26,7 +26,10 @@
>  #include <asm/irq.h>
>  #include <asm/uaccess.h>
>  #include <asm/io.h>
> +
> +#ifdef CONFIG_MIPS
>  #include <asm/bootinfo.h>
> +#endif
>  
>  void SELECT_MASK(ide_drive_t *drive, int mask)
>  {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/