linux-kernel - Re: [PATCH] regulator: Get rid of lockdep warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100312172156.GB22822@rakim.wolfsonmicro.main>
Date:	Fri, 12 Mar 2010 17:21:56 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ameya Palande <ameya.palande@...ia.com>
Cc:	linux-kernel@...r.kernel.org, lrg@...mlogic.co.uk,
	dbrownell@...rs.sourceforge.net
Subject: Re: [PATCH] regulator: Get rid of lockdep warning

On Fri, Mar 12, 2010 at 07:16:36PM +0200, Ameya Palande wrote:

> @@ -1045,6 +1045,7 @@ static struct regulator *create_regulator(struct regulator_dev *rdev,
>  		regulator->dev_attr.attr.owner = THIS_MODULE;
>  		regulator->dev_attr.attr.mode = 0444;
>  		regulator->dev_attr.show = device_requested_uA_show;
> +		sysfs_attr_init(&regulator->dev_attr.attr);
>  		err = device_create_file(dev, &regulator->dev_attr);
>  		if (err < 0) {
>  			printk(KERN_WARNING "%s: could not add regulator_dev"

Without having looked at what sysfs_attr_init() is actually doing it
looks odd to be calling an init() function after having initialised
several members of the structure - I'd expect to see the call happen
before we start writing stuff in?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/