linux-kernel - RE: [PATCH] Don't change direction flags in struct request.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <233671224A0FED4688218FFDBED26E1A55321707E4@IRVEXCHCCR01.corp.ad.broadcom.com>
Date:	Fri, 12 Mar 2010 14:26:33 -0800
From:	"Hugh Daschbach" <hdasch@...adcom.com>
To:	"Mike Christie" <michaelc@...wisc.edu>
cc:	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	"Chandra Seetharaman" <sekharan@...ibm.com>,
	"Eddie Williams" <Eddie.Williams@...eleye.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Don't change direction flags in struct request.

Mike Christie [mailto:michaelc@...wisc.edu] writes:

> On 03/19/2010 12:31 AM, Hugh Daschbach wrote:
>> The EMC multipath device handler should not change the I/O direction
>> flags of its trespass command request.

...

> Did you try the patch I linked to the last time you posted about this?

I have not.  When I read it, I believed it would fix the issue.

> I think there should be a patch which fixes this problem here:
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commitdiff;h=6c71dcb28ff9b63b814a0b76a256f5dae08d3e0d;hp=3a5b27bf6f29574d667230c7e76e4b83fe3014e0
> I think it got into 2.6.34-rc1.

Then I'll pull it and test it.

> With that patch mode selects should get set up as writes.
>
> Does it work? If it does then I think we just need the attached cleanup 
> patch which removes the cmd_flags setting. The patch that got merged 
> fixed the problem of initializing the request properly, but it forgot to 
> remove the cmd_flags setting.

Agree.  I'll test it early next week and confirm.

Thanks,
Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/