lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Mar 2010 14:56:31 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: Ferenc Wagner <wferi@...f.hu> Cc: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry On Sat, 06 Mar 2010 20:08:00 +0100 Ferenc Wagner <wferi@...f.hu> wrote: > Subject: [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry fyi, the text inside [] is conventionally considered "transient, to be removed by receiver", so you should have placed the subsystem-identification text outside the []. > Actually, this embedded struct (together with nandsim_regs) could as well > remain nameless... > Sounds like a fine idea. > --- > drivers/mtd/nand/nandsim.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c > index 7281000..803ae12 100644 > --- a/drivers/mtd/nand/nandsim.c > +++ b/drivers/mtd/nand/nandsim.c > @@ -312,7 +312,7 @@ struct nandsim { > union ns_mem buf; > > /* NAND flash "geometry" */ > - struct nandsin_geometry { > + struct nandsim_geometry { > uint64_t totsz; /* total flash size, bytes */ > uint32_t secsz; /* flash sector (erase block) size, bytes */ > uint pgsz; /* NAND flash page size, bytes */ this: From: Ferenc Wagner <wferi@...f.hu> The name was spelled wrong. We don't need an identifier on this struct anyway, so remove it altogether. Signed-off-by: Ferenc Wagner <wferi@...f.hu> Cc: David Woodhouse <dwmw2@...radead.org> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> --- drivers/mtd/nand/nandsim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/mtd/nand/nandsim.c~mtd-nandsim-fix-typo-struct-nandsin_geometry drivers/mtd/nand/nandsim.c --- a/drivers/mtd/nand/nandsim.c~mtd-nandsim-fix-typo-struct-nandsin_geometry +++ a/drivers/mtd/nand/nandsim.c @@ -315,7 +315,7 @@ struct nandsim { union ns_mem buf; /* NAND flash "geometry" */ - struct nandsin_geometry { + struct { uint64_t totsz; /* total flash size, bytes */ uint32_t secsz; /* flash sector (erase block) size, bytes */ uint pgsz; /* NAND flash page size, bytes */ _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists