linux-kernel - Re: [tip:sched/core] sched: Remove AFFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1268368639.6302.2.camel@marge.simson.net>
Date:	Fri, 12 Mar 2010 05:37:19 +0100
From:	Mike Galbraith <efault@....de>
To:	Yong Zhang <yong.zhang@...driver.com>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	a.p.zijlstra@...llo.nl, tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/core] sched: Remove AFFINE_WAKEUPS feature

On Fri, 2010-03-12 at 11:23 +0800, Yong Zhang wrote:
> On Thu, Mar 11, 2010 at 06:33:38PM +0000, tip-bot for Mike Galbraith wrote:
> > Commit-ID:  beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8
> > Gitweb:     http://git.kernel.org/tip/beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8
> > Author:     Mike Galbraith <efault@....de>
> > AuthorDate: Thu, 11 Mar 2010 17:17:20 +0100
> > Committer:  Ingo Molnar <mingo@...e.hu>
> > CommitDate: Thu, 11 Mar 2010 18:32:53 +0100
> > 
> > sched: Remove AFFINE_WAKEUPS feature
> > 
> > Disabling affine wakeups is too horrible to contemplate.  Remove the feature flag.
> 
> AFFINE_WAKEUPS is still left in sched_feature.h

Oops, axe got dull.  Thanks for checking.

	-Mike

> From: Yong Zhang <yong.zhang@...driver.com>
> Date: Fri, 12 Mar 2010 11:14:26 +0800
> Subject: [PATCH] sched: clean AFFINE_WAKEUPS feature
> 
> complementary work to commit beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8
> 
> Signed-off-by: Yong Zhang <yong.zhang@...driver.com>
> ---
>  kernel/sched_features.h |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)
> 
> diff --git a/kernel/sched_features.h b/kernel/sched_features.h
> index 83c66e8..2137ac0 100644
> --- a/kernel/sched_features.h
> +++ b/kernel/sched_features.h
> @@ -17,14 +17,6 @@ SCHED_FEAT(START_DEBIT, 1)
>  SCHED_FEAT(WAKEUP_PREEMPT, 1)
>  
>  /*
> - * Based on load and program behaviour, see if it makes sense to place
> - * a newly woken task on the same cpu as the task that woke it --
> - * improve cache locality. Typically used with SYNC wakeups as
> - * generated by pipes and the like, see also SYNC_WAKEUPS.
> - */
> -SCHED_FEAT(AFFINE_WAKEUPS, 1)
> -
> -/*
>   * Prefer to schedule the task we woke last (assuming it failed
>   * wakeup-preemption), since its likely going to consume data we
>   * touched, increases cache locality.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/