linux-kernel - Re: Using tracing_off() in __schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Mar 2010 21:30:44 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Chase Douglas <chase.douglas@...onical.com>
Cc:	linux-kernel@...r.kernel.org,
	kernel-team <kernel-team@...ts.ubuntu.com>
Subject: Re: Using tracing_off() in __schedule_bug()

On Fri, 2010-03-12 at 21:12 -0500, Chase Douglas wrote:
> On Fri, Mar 12, 2010 at 6:34 PM, Steven Rostedt <rostedt@...dmis.org> wrote:

> > Hmm, thinking about it more, I would rather have a separate function,
> > that would call tracing_off() if some variable is set. By default it
> > would be set, but in case you want to keep tracing after a bug is hit,
> > you can have a way to disable it.
> >
> > I need to write up a patch soon. Thanks for bring this up.
> 
> I'd be happy to help out in this endeavor if you'd like. I'm wondering
> if there shouldn't be multiple levels of tracing_off support specified
> at boot time (disabled on WARNING, BUG, __schedule_bug, OOPS) in an
> ordered priority way. I.e. tracing_off_bug would leave tracing on for
> WARNING's, but turn it off for BUG's, schedule bugs, and oopses. The
> default would be tracing_off_warn, which would call tracing_off on all
> of the above.

I think that's a bit over-engineering. I'd suggest that you either want
to disable tracing on an error or you don't. I could add a tracing
option that lets you stop it. Keep it simple. If it becomes complex, no
one will use it.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/