linux-kernel - [PATCH] Security: Add break judge to smk_import_entry() in security/smack/smack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100313132545.GB3126@localhost.localdomain>
Date:	Sat, 13 Mar 2010 21:25:45 +0800
From:	wzt.wzt@...il.com
To:	linux-kernel@...r.kernel.org
Cc:	linux-security-module@...r.kernel.org, sds@...ho.nsa.gov,
	casey@...aufler-ca.com
Subject: [PATCH] Security: Add break judge to smk_import_entry() in security/smack/smack_access.c

In smk_import_entry(), smack[i] = '\0' was set if found = 1, so:
if (found)
	smack[i] = '\0';
No need to continue again, just can break the loop.

Signed-off-by: Zhitong Wang <zhitong.wangzt@...baba-inc.com>

---
 security/smack/smack_access.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/security/smack/smack_access.c b/security/smack/smack_access.c
index 0f9ac81..0e064e8 100644
--- a/security/smack/smack_access.c
+++ b/security/smack/smack_access.c
@@ -318,7 +318,7 @@ struct smack_known *smk_import_entry(const char *string, int len)
 
 	for (i = 0, found = 0; i < SMK_LABELLEN; i++) {
 		if (found)
-			smack[i] = '\0';
+			break;
 		else if (i >= len || string[i] > '~' || string[i] <= ' ' ||
 			 string[i] == '/' || string[i] == '"' ||
 			 string[i] == '\\' || string[i] == '\'') {
-- 
1.6.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/