linux-kernel - Re: [PATCH] staging: winbond: Formatting, whitespace etc in mds.c I fixed most of the problems found by checkpatch.pl. Some long lines are left and some KERN_.. Signed-off-by: Lars Lindley <lindley@...ote.org>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B9B6ADC.6060204@s5r6.in-berlin.de>
Date:	Sat, 13 Mar 2010 11:37:16 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Lars Lindley <lindley@...ote.org>
CC:	Pavel Machek <pavel@....cz>, gregkh@...e.de,
	penberg@...helsinki.fi, diegoliz@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: Formatting, whitespace etc in mds.c
 I fixed most of the problems found by checkpatch.pl. Some long lines are
 left and some KERN_.. Signed-off-by: Lars Lindley <lindley@...ote.org>

Lars Lindley wrote:
> +		} else { /*DSSS*/
> +			/*CTS duration
> +			 *2 SIFS + DATA transmit time + 1 ACK
> +			 * Rate : ?? Mega bps
> +			 *ACK frame length = 14 bytes*/
> +			if (pT01->T01_plcp_header_length) /*long preamble*/
> +			    Duration = LONG_PREAMBLE_PLUS_PLCPHEADER_TIME*2;
>  			else
> -				Duration = SHORT_PREAMBLE_PLUS_PLCPHEADER_TIME*2;
> +			    Duration = SHORT_PREAMBLE_PLUS_PLCPHEADER_TIME*2;

Multiline comments are formatted as
/*
 * 1st line
 * last line
 */
in new code.

The whitespace in the if--else clause went worse.  Indent by tabs, not
spaces.  Furthermore, there should be spaces around * operators.

(BTW, winbond/README alias winbond/TODO doesn't mention it, but another
(trivial) step is going to be to change variable names and function
names from CamelCase to lower_case spelling.)
-- 
Stefan Richter
-=====-==-=- --== -==-=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/