linux-kernel - Re: [PATCH] staging: winbond: mds.c whitspace, indentation etc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100313144021.GA19207@bicker>
Date:	Sat, 13 Mar 2010 17:40:21 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Lars Lindley <lindley@...ote.org>
Cc:	gregkh@...e.de, greg@...ah.com, penberg@...helsinki.fi,
	pavel@....cz, diegoliz@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: mds.c whitspace, indentation etc.

First of all, thanks for the patch.  I verified that the compiled version
was the same before and after.  It cleans up the code a lot.

> +		} else { /*DSSS*/
> +			/*CTS duration
> +			 *2 SIFS + DATA transmit time + 1 ACK
> +			 * Rate : ?? Mega bps
> +			 *ACK frame length = 14 bytes
> +			 */

There are a couple places like this.  Could you put spaces between the
'*' and the first character?  In fact those two comments could be combined
probably.

Once you fix that, check everything again and resend.  Looks good.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/