linux-kernel - Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style guidelines and verified by checkpatch.pl tool.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100313.114939.120459447.davem@davemloft.net>
Date:	Sat, 13 Mar 2010 11:49:39 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sjharms@...il.com
Cc:	mcarlson@...adcom.com, mchan@...adcom.com, benli@...adcom.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	sharms@...ntu.com
Subject: Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding
 style in tg3.c This is a patch to the tg3.c file that aligns switch and
 case statements, else statements following braces, and inserts a space
 after commas listed in the coding style guidelines and verified by
 checkpatch.pl tool.

From: Steven Harms <sjharms@...il.com>
Date: Sat, 13 Mar 2010 14:39:11 -0500

> -#define tw32_mailbox(reg, val)	tp->write32_mbox(tp, reg, val)
> -#define tw32_mailbox_f(reg, val)	tw32_mailbox_flush(tp, (reg), (val))
> -#define tw32_rx_mbox(reg, val)	tp->write32_rx_mbox(tp, reg, val)
> -#define tw32_tx_mbox(reg, val)	tp->write32_tx_mbox(tp, reg, val)
> -#define tr32_mailbox(reg)	tp->read32_mbox(tp, reg)
> +#define tw32_mailbox(reg, val)	(tp->write32_mbox(tp, reg, val))

Please keep this kind of code masterbation to yourself.
This is not the style we want for this driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/