linux-kernel - Re: [PATCH] XEN: Make handle_vcpu_hotplug_event() to check the sscanf() return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B9ADEC0.60302@goop.org>
Date:	Fri, 12 Mar 2010 16:39:28 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	wzt.wzt@...il.com
CC:	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com,
	jeremy@...source.com
Subject: Re: [PATCH] XEN: Make handle_vcpu_hotplug_event() to check the sscanf()
 return value

On 03/11/2010 06:53 PM, wzt.wzt@...il.com wrote:
> It seems handle_vcpu_hotplug_event() not check the sscanf() return value.
>
> Signed-off-by: Zhitong Wang<zhitong.wangzt@...baba-inc.com>
>    

Good catch, thanks.

     J

> ---
>   drivers/xen/cpu_hotplug.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
> index 14e2d99..99773a6 100644
> --- a/drivers/xen/cpu_hotplug.c
> +++ b/drivers/xen/cpu_hotplug.c
> @@ -69,8 +69,8 @@ static void handle_vcpu_hotplug_event(struct xenbus_watch *watch,
>
>   	cpustr = strstr(node, "cpu/");
>   	if (cpustr != NULL) {
> -		sscanf(cpustr, "cpu/%u",&cpu);
> -		vcpu_hotplug(cpu);
> +		if (sscanf(cpustr, "cpu/%u",&cpu) == 1)
> +			vcpu_hotplug(cpu);
>   	}
>   }
>
>    

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/