linux-kernel - Re: should new kfifo implementation really be exporting that much?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B9D10D1.1060602@phoenixsoftware.de>
Date:	Sun, 14 Mar 2010 17:37:37 +0100
From:	Tilman Schmidt <t.schmidt@...enixsoftware.de>
To:	"Robert P. J. Day" <rpjday@...shcourse.ca>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: should new kfifo implementation really be exporting that much?

Am 14.03.2010 15:57 schrieb Robert P. J. Day:
>   as a short followup, kfifo.h strongly implies that a lot of the
> above shouldn't be exported:
> 
> ...
> /*
>  * __kfifo_in_... internal functions for put date into the fifo
>  * do not call it directly, use kfifo_in_rec() instead
>  */
> ...
> 
>   anyway, you get the idea.  it would seem that a lot of those EXPORTs
> should be removed, no?

If you look at kfifo_in_rec(), it's a static inline void function
defined in kfifo.h and which calls __kfifo_in_generic() or
__kfifo_in_rec(). I don't think you'll be able to make that work
without exporting those functions.

HTH
T.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/