linux-kernel - Re: [PATCHv2] USB: composite: allow optional removal of __init and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <op.u9mjercl7p4s8u@pikus>
Date:	Mon, 15 Mar 2010 20:36:17 +0100
From:	Michał Nazarewicz <m.nazarewicz@...sung.com>
To:	me@...ipebalbi.com
Cc:	linux-usb@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	gregkh@...e.de, linux-kernel@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCHv2] USB: composite: allow optional removal of __init and
 __exit tags

> On Mon, Mar 15, 2010 at 01:48:18PM +0100, Michal Nazarewicz wrote:
>> The composite framework has been written using __init and __exit tags
>> to mark init and exit functions as such.  This works with most of the
>> composite gadgets however some may need to call init/exit functions
>> during normal operations.  One example is mass storage gadget which
>> needs to call exit functions.
>>
>> This patch allows gadgets to define USB_NO_INIT_SEGMENT or
>> USB_NO_EXIT_SEGMENT to remove the __init and __exit declarations
>> from composite framework.

On Mon, 15 Mar 2010 19:06:15 +0100, Felipe Balbi <me@...ipebalbi.com> wrote:
> wouldn't it be the same as changing from __init to __devinit and __exit
> to __devexit ??

Most of existing composite gadgets work fine with __init/__exit and I
didn't want to change their behaviour therefore changing it simply to
__devinit/__devexit would in most cases cancel the micro-optimisation
that __init/__exit bring.

Besides, I think that changing it to __devinit/__devexit won't solve
the problem that my patch is solving.  If I'm not mistaken USB gadget
and thus USB composite gadget can be registered/unregistered at any
time without support for hotplug (which, if my understanding is
correct, is the only situation when __devinit/__devexit matters) and
so on systems w/o hotplug still init and exit functions won't be
available while the module is loaded.

-- 
Best regards,                                           _     _
  .o. | Liege of Serenely Enlightened Majesty of       o' \,=./ `o
  ..o | Computer Science,  Michał "mina86" Nazarewicz     (o o)
  ooo +---[mina86@...a86.com]---[mina86@...ber.org]---ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/