linux-kernel - Re: [PATCH 2/4] Fix typo: udpate => update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B9EA92B.1020404@s5r6.in-berlin.de>
Date:	Mon, 15 Mar 2010 22:39:55 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Thomas Weber <swirl@....li>
CC:	linux-kernel@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 2/4] Fix typo: udpate => update

Thomas Weber wrote:
> Signed-off-by: Thomas Weber <swirl@....li>
> ---
>  Documentation/kbuild/kconfig.txt            |    2 +-
>  drivers/firewire/ohci.c                     |    2 +-

The firewire part is of course
Acked-by: Stefan Richter <stefanr@...6.in-berlin.de>

>  drivers/infiniband/hw/ipath/ipath_iba6110.c |    2 +-
>  drivers/infiniband/hw/ipath/ipath_iba6120.c |    4 ++--
>  drivers/infiniband/hw/ipath/ipath_iba7220.c |    2 +-
>  drivers/isdn/hisax/hfc4s8s_l1.c             |    2 +-
>  drivers/staging/rtl8187se/r8180_core.c      |    4 ++--

See comment on this part below.

>  drivers/staging/rtl8187se/r8180_dm.c        |    2 +-
>  drivers/staging/rtl8187se/r8185b_init.c     |    2 +-

Ditto.

>  fs/jfs/jfs_dmap.c                           |    2 +-
>  10 files changed, 12 insertions(+), 12 deletions(-)
> 
[...]
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -2364,7 +2364,7 @@ void rtl8180_wmm_param_update(struct work_struct * work)
>  				u8		u1bAIFS;
>  				u32		u4bAcParam;
>  				pAcParam = (PAC_PARAM)(&AcParam);
> -				// Retrive paramters to udpate.
> +				// Retrive paramters to update.
>  				u1bAIFS = pAcParam->f.AciAifsn.f.AIFSN *(((mode&IEEE_G) == IEEE_G)?9:20) + aSifsTime;
>  				u4bAcParam = ((((u32)(pAcParam->f.TXOPLimit))<<AC_PARAM_TXOP_LIMIT_OFFSET)|
>  					      (((u32)(pAcParam->f.Ecw.f.ECWmax))<<AC_PARAM_ECW_MAX_OFFSET)|

"Retrieve" and "parameters".
(You are fixing "parameters" in patch 3/4 --- why not right here?)

> @@ -2400,7 +2400,7 @@ void rtl8180_wmm_param_update(struct work_struct * work)
>  			u8		u1bAIFS;
>  			u32		u4bAcParam;
>  
> -			// Retrive paramters to udpate.
> +			// Retrive paramters to update.
>  			eACI = pAcParam->f.AciAifsn.f.ACI;
>  			//Mode G/A: slotTimeTimer = 9; Mode B: 20
>  			u1bAIFS = pAcParam->f.AciAifsn.f.AIFSN * (((mode&IEEE_G) == IEEE_G)?9:20) + aSifsTime;

Ditto.

> --- a/drivers/staging/rtl8187se/r8185b_init.c
> +++ b/drivers/staging/rtl8187se/r8185b_init.c
> @@ -1128,7 +1128,7 @@ ActUpdateChannelAccessSetting(
>  				u8		u1bAIFS;
>  				u32		u4bAcParam;
>  
> -				// Retrive paramters to udpate.
> +				// Retrive paramters to update.
>  				eACI = pAcParam->f.AciAifsn.f.ACI;
>  				u1bAIFS = pAcParam->f.AciAifsn.f.AIFSN * ChnlAccessSetting->SlotTimeTimer + aSifsTime;
>  				u4bAcParam = (	(((u32)(pAcParam->f.TXOPLimit)) << AC_PARAM_TXOP_LIMIT_OFFSET)	|

Ditto.

By the way, some of the staging drivers are undergoing heavy
reformatting, hence it may be better to submit spelling fixes in those
separately from non-staging code.  (I don't know if this is the case
with rtl8187se in particular.)
-- 
Stefan Richter
-=====-==-=- --== -====
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/