linux-kernel - Re: [PATCH v2] perf: Fix unexported generic perf_arch_fetch_caller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100316093355.071fde51.sfr@canb.auug.org.au>
Date:	Tue, 16 Mar 2010 09:33:55 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	"\\ \" H . Peter Anvin \\ \"" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Next <linux-next@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH v2] perf: Fix unexported generic
 perf_arch_fetch_caller_regs

Hi Frederic,

On Mon, 15 Mar 2010 23:17:22 +0100 Frederic Weisbecker <fweisbec@...il.com> wrote:
>
> perf_arch_fetch_caller_regs() is exported for the overriden x86
> version, but not for the generic weak version.
> As a general rule, weak functions should have their symbol exported
                                          ^
"not"

> in the same file they are defined.
> 
> So let's export it on trace_event_perf.c as it is used by trace
> events only.

Otherwise, looks good (though I haven't tested it).

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped