linux-kernel - RE: [PATCH] Regulators: lp3971 - Fix setting val for LDO2 and LDO4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <000001cac40b$07368ba0$15a3a2e0$%szyprowski@samsung.com>
Date:	Mon, 15 Mar 2010 07:44:53 +0100
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	'Mark Brown' <broonie@...nsource.wolfsonmicro.com>,
	'axel lin' <axel.lin@...il.com>
Cc:	'linux-kernel' <linux-kernel@...r.kernel.org>,
	'Kyungmin Park' <kyungmin.park@...sung.com>,
	lrg@...mlogic.co.uk
Subject: RE: [PATCH] Regulators: lp3971 - Fix setting val for LDO2 and LDO4

Hello,

On Wednesday, March 10, 2010 6:07 PM Mark Brown wrote:

> On Wed, Mar 10, 2010 at 08:29:40AM +0800, axel lin wrote:
> > From: Axel Lin <axel.lin@...il.com>
> > Date: Tue, 9 Mar 2010 16:53:59 +0800
> > Subject: [PATCH] lp3971: Fix setting val for LDO2 and LDO4
> >
> > In lp3971_ldo_set_voltage function, it requires val to left shift 4
> > bits for LDO2 and LDO4.
> > This patch fix this issue.
> >
> > Signed-off-by: Axel Lin <axel.lin@...il.com>
> 
> Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> 
> but I really would prefer to see one of the Samsung folks comment.

Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>

This was definitely a bug. Thanks for spotting it.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/