linux-kernel - Re: [PATCH v2] microblaze: Fix Makefile to delete build generated files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B9F4988.20809@monstr.eu>
Date:	Tue, 16 Mar 2010 10:04:08 +0100
From:	Michal Simek <monstr@...str.eu>
To:	Arun Bhanu <arun@...nu.net>
CC:	linux-kernel@...r.kernel.org, microblaze-uclinux@...e.uq.edu.au,
	sam@...nborg.org
Subject: Re: [PATCH v2] microblaze: Fix Makefile to delete build generated
 files

Arun Bhanu wrote:
> 'make clean' does not to delete the following build generated file:
> 	arch/microblaze/boot/linux.bin.ub
> 
> 'make mrproper' does not to delete the following build generated files:
> 	arch/microblaze/boot/simpleImage.*
> 
> Fix the Makefile to delete these build generated files.
> 
> See [1] for a discussion on why simpleImage.* files are deleted with 'make
> mrproper' and not with 'make clean'.
> 	[1] http://lkml.org/lkml/2010/3/12/96
> 
> Signed-off-by: Arun Bhanu <arun@...nu.net>
> ---
>  arch/microblaze/Makefile      |    2 ++
>  arch/microblaze/boot/Makefile |    2 +-
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile
> index d2d6cfc..36926b9 100644
> --- a/arch/microblaze/Makefile
> +++ b/arch/microblaze/Makefile
> @@ -93,3 +93,5 @@ define archhelp
>    echo '  name of a dts file from the arch/microblaze/boot/dts/ directory'
>    echo '  (minus the .dts extension).'
>  endef
> +
> +MRPROPER_FILES += $(boot)/simpleImage.*

I personally don't like that this line is in main arch Makefile but I 
saw that other archs have it too. Will be better to have it only in boot 
folder but I don't know if is possible to do that.
Sam: What do you think?


> diff --git a/arch/microblaze/boot/Makefile b/arch/microblaze/boot/Makefile
> index 902cf98..a1fc324 100644
> --- a/arch/microblaze/boot/Makefile
> +++ b/arch/microblaze/boot/Makefile
> @@ -64,4 +64,4 @@ $(obj)/%.dtb: $(dtstree)/%.dts FORCE
>  
>  clean-kernel += linux.bin linux.bin.gz simpleImage.*
>  
> -clean-files += *.dtb simpleImage.*.unstrip
> +clean-files += *.dtb simpleImage.*.unstrip linux.bin.ub

Could you please take a look at clean-kernel option too?
I think we can simple remove it. It should be any ancient code from powerpc.

Thanks,
Michal




-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/