linux-kernel - Re: [RFC] remove implicit slab.h inclusion from percpu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f021003160206l7c8895aby5e54d0b54c3bd8eb@mail.gmail.com>
Date:	Tue, 16 Mar 2010 11:06:27 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Tejun Heo <tj@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>,
	Christoph Lameter <cl@...ux-foundation.org>
Subject: Re: [RFC] remove implicit slab.h inclusion from percpu.h

On Tue, Mar 16, 2010 at 10:23 AM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> On Tue, Mar 16, 2010 at 9:56 AM, Pekka Enberg <penberg@...helsinki.fi> wrote:
>> Alexey Dobriyan kirjoitti:
>>>
>>> On Tue, Mar 16, 2010 at 8:58 AM, Pekka Enberg <penberg@...helsinki.fi>
>>> wrote:
>>>>
>>>> We should avoid creating tree-wide breakage for this kind of cleanups.
>>>
>>> This is done by compile testing, not by being smartass.
>>
>> I don't think compile testing is going to scale here because slab is used is
>> so many places of the kernel.
>
> Sigh.
>
> If you want to skip compile testing, just say so in changelog.

Hey, "sigh" right back at you, Alexey!

I am not saying I want to skip "compile testing", I'm just stating the
obvious fact: for a header such as slab.h that's implicitly needed in
pretty much everywhere, it's very difficult to find all the relevant
broken configurations. I don't see the benefit of breaking the world
for this cleanup as Ingo's suggestion will eventually get us to the
exact same situation _without_ causing tree-wide breakage.

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/