linux-kernel - Re: [Stable-review] [patch 070/123] ath9k: re-enable ps by default for new single chip families

Open Source and information security mailing list archives

Date:	Mon, 15 Mar 2010 18:04:15 -0700
From:	"Luis R. Rodriguez" <lrodriguez@...eros.com>
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	torvalds@...ux-foundation.org,
	"John W. Linville" <linville@...driver.com>,
	Kristoffer Ericson <kristoffer.ericson@...il.com>,
	"Justin P. Mattock" <justinmattock@...il.com>,
	akpm@...ux-foundation.org, Peter Stuge <peter@...ge.se>,
	stable-review@...nel.org, alan@...rguk.ukuu.org.uk
Subject: Re: [Stable-review] [patch 070/123] ath9k: re-enable ps by default 
	for new single chip families

On Fri, Mar 12, 2010 at 5:12 PM, Greg KH <gregkh@...e.de> wrote:
> 2.6.33-stable review patch.  If anyone has any objections, please let me know.

This was intended for 2.6.32 as well. Thanks

  Luis
> -----------------
>
> From: Luis R. Rodriguez <lrodriguez@...eros.com>
>
> commit 14acdde6e527950f66c084dbf19bad6fbfcaeedc upstream.
>
> The newer single chip hardware family of chipsets have not been
> experiencing issues with power saving set by default with recent
> fixes merged (even into stable). The remaining issues are only
> reported with AR5416 and since enabling PS by default can increase
> power savings considerably best to take advantage of that feature
> as this has been tested properly.
>
> For more details on this issue see the bug report:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=14267
>
> We leave AR5416 with PS disabled by default, that seems to require
> some more work.
>
> Cc: Peter Stuge <peter@...ge.se>
> Cc: Justin P. Mattock  <justinmattock@...il.com>
> Cc: Kristoffer Ericson <kristoffer.ericson@...il.com>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@...eros.com>
> Signed-off-by: John W. Linville <linville@...driver.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
>
> ---
>  drivers/net/wireless/ath/ath9k/main.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -1849,6 +1849,8 @@ bad_free_hw:
>
>  void ath_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
>  {
> +       struct ath_hw *ah = sc->sc_ah;
> +
>        hw->flags = IEEE80211_HW_RX_INCLUDES_FCS |
>                IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
>                IEEE80211_HW_SIGNAL_DBM |
> @@ -1866,7 +1868,8 @@ void ath_set_hw_capab(struct ath_softc *
>                BIT(NL80211_IFTYPE_ADHOC) |
>                BIT(NL80211_IFTYPE_MESH_POINT);
>
> -       hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> +       if (AR_SREV_5416(ah))
> +               hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
>
>        hw->queues = 4;
>        hw->max_rates = 4;
>
>
> _______________________________________________
> Stable-review mailing list
> Stable-review@...ux.kernel.org
> http://linux.kernel.org/mailman/listinfo/stable-review
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives