linux-kernel - Re: [PATCH] perf: install into /usr/local by default.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100316102546.GE10069@elte.hu>
Date:	Tue, 16 Mar 2010 11:25:46 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Avi Kivity <avi@...hat.com>
Cc:	T??r??k Edwin <edwintorok@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	linux-kernel@...r.kernel.org,
	Fr?d?ric Weisbecker <fweisbec@...il.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH] perf: install into /usr/local by default.


* Avi Kivity <avi@...hat.com> wrote:

> On 03/16/2010 12:10 PM, Ingo Molnar wrote:
> >* T??r??k Edwin<edwintorok@...il.com>  wrote:
> >
> >>It was confusing to install into $(HOME)/bin, especially since there was
> >>no documentation mentioning where perf gets installed by default.
> >>So install to /usr/local by default, as other programs do, and allow users to
> >>override the install location by specifying the prefix explicitly.
> >>
> >>Signed-off-by: T??r??k Edwin<edwintorok@...il.com>
> >>---
> >>  tools/perf/Makefile |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >>diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> >>index 2e7fa3a..8e8c199 100644
> >>--- a/tools/perf/Makefile
> >>+++ b/tools/perf/Makefile
> >>@@ -216,7 +216,7 @@ STRIP ?= strip
> >>  # runtime figures out where they are based on the path to the executable.
> >>  # This can help installing the suite in a relocatable way.
> >>
> >>-prefix = $(HOME)
> >>+prefix = /usr/local
> >>  bindir_relative = bin
> >>  bindir = $(prefix)/$(bindir_relative)
> >>  mandir = share/man
> >Btw., we inherited that default prefix from the Git project.
> >
> >Is there a way to get it into ~/bin/ if the user does not have permission to
> >/usr/local ? (i.e. doesnt run it as root)
> >
> >That's a really convenient aspect of doing a 'make install' as user. (Which i
> >tend to do in most cases)
> 
> What about people (like me) who do 'make && sudo make install'?

I'd like everyone to be happy :-)

In case of irreconcilable differences i prefer the creation of two parallel 
universes, one for each variant. This does not seem to be such a case though:

> Can we make it position independent and derive the path from /proc/$$/exe?

Sounds like a useful approach ...

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/