| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1268739988.17270.8.camel@ICE-BOX> Date: Tue, 16 Mar 2010 22:46:28 +1100 From: Darren Jenkins <darrenrjenkins@...il.com> To: Inaky Perez-Gonzalez <inaky.perez-gonzalez@...el.com>, linux-wimax@...el.com, Kernel Janitors <kernel-janitors@...r.kernel.org> Cc: Cindy H Kao <cindy.h.kao@...el.com>, Dirk Brandewie <dirk.j.brandewie@...el.com>, wimax@...uxwimax.org, netdev@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: [PATCH] drivers/net/wimax/i2400m/fw.c fix possible double free i2400m_fw_check() can free i2400m->fw_hdrs if krealloc() fails causing a double free Add a check so we don't free the memory a second time. coverity CID: 13455 Signed-off-by: Darren Jenkins <darrenrjenkins@...il.com> --- drivers/net/wimax/i2400m/fw.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/wimax/i2400m/fw.c b/drivers/net/wimax/i2400m/fw.c index 25c24f0..a97c413 100644 --- a/drivers/net/wimax/i2400m/fw.c +++ b/drivers/net/wimax/i2400m/fw.c @@ -1490,7 +1490,8 @@ int i2400m_fw_bootstrap(struct i2400m *i2400m, const struct firmware *fw, if (ret < 0) dev_err(dev, "%s: cannot use: %d, skipping\n", i2400m->fw_name, ret); - kfree(i2400m->fw_hdrs); + if (ret != -ENOMEM) + kfree(i2400m->fw_hdrs); i2400m->fw_hdrs = NULL; d_fnend(5, dev, "(i2400m %p) = %d\n", i2400m, ret); return ret; -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists