linux-kernel - [PATCH 1/1] GPU: vga_switcheroo, fix lock imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1268750751-13087-1-git-send-email-jslaby@suse.cz>
Date:	Tue, 16 Mar 2010 15:45:51 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	airlied@...hat.com
Cc:	linux-kernel@...r.kernel.org, jirislaby@...il.com
Subject: [PATCH 1/1] GPU: vga_switcheroo, fix lock imbalance

Stanse found that one error path in vga_switcheroo_debugfs_write
omits to unlock vgasr_mutex. Fix that.

Signed-off-by: Jiri Slaby <jslaby@...e.cz>
Cc: Dave Airlie <airlied@...hat.com>
---
 drivers/gpu/vga/vga_switcheroo.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/vga/vga_switcheroo.c b/drivers/gpu/vga/vga_switcheroo.c
index d6d1149..c8768f3 100644
--- a/drivers/gpu/vga/vga_switcheroo.c
+++ b/drivers/gpu/vga/vga_switcheroo.c
@@ -276,8 +276,10 @@ vga_switcheroo_debugfs_write(struct file *filp, const char __user *ubuf,
 
 	mutex_lock(&vgasr_mutex);
 
-	if (!vgasr_priv.active)
-		return -EINVAL;
+	if (!vgasr_priv.active) {
+		cnt = -EINVAL;
+		goto out;
+	}
 
 	/* pwr off the device not in use */
 	if (strncmp(usercmd, "OFF", 3) == 0) {
-- 
1.7.0.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/