linux-kernel - Re: [PATCH 1/3] SCSI: be2iscsi, fix lock imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100316204810.47e381d0@mailhost.serverengines.com>
Date:	Tue, 16 Mar 2010 13:48:10 -0700
From:	"Jayamohan Kalickal" <jayamohank@...verengines.com>
To:	"Jiri Slaby" <jslaby@...e.cz>, James.Bottomley@...e.de
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	jirislaby@...il.com
Subject: Re: [PATCH 1/3] SCSI: be2iscsi, fix lock imbalance

Acked-By:  Jayamohan Kallickal <jayamohank@...verengines.com>

--
  _____  
From: Jiri Slaby [mailto:jslaby@...e.cz]
To: James.Bottomley@...e.de
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, jirislaby@...il.com, Jayamohan Kallickal [mailto:jayamohank@...verengines.com]
Sent: Tue, 16 Mar 2010 08:23:57 -0700
Subject: [PATCH 1/3] SCSI: be2iscsi, fix lock imbalance

Stanse found that one error path in mgmt_invalidate_icds omits to unlock
ctrl->mbox_lock. Fix that.

Added in 756d29c8c7ed8887ed7d752371ce2f (Enable async mode for mcc rings)
where the spinlock was moved.

Signed-off-by: Jiri Slaby <jslaby@...e.cz>
Cc: Jayamohan Kallickal <jayamohank@...verengines.com>
Cc: James Bottomley <James.Bottomley@...e.de>
---
 drivers/scsi/be2iscsi/be_mgmt.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
index 72617b6..e641922 100644
--- a/drivers/scsi/be2iscsi/be_mgmt.c
+++ b/drivers/scsi/be2iscsi/be_mgmt.c
@@ -169,6 +169,7 @@ unsigned char mgmt_invalidate_icds(struct beiscsi_hba *phba,
 		SE_DEBUG(DBG_LVL_1,
 			 "Failed to allocate memory for"
 			 "mgmt_invalidate_icds \n");
+		spin_unlock(&ctrl->mbox_lock);
 		return -1;
 	}
 	nonemb_cmd.size = sizeof(struct invalidate_commands_params_in);
-- 
1.7.0.1


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of
ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly prohibited.  If you are not the
intended recipient of this message, please immediately advise the sender by reply email message and
delete all copies of this message and any attachment(s). Thank you.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/