linux-kernel - Re: [PATCH] drm: Allow platform devices to register as DRM devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100316024154.GC17028@linux-sh.org>
Date:	Tue, 16 Mar 2010 11:41:54 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Dave Airlie <airlied@...il.com>
Cc:	Jordan Crouse <jcrouse@...eaurora.org>,
	dri-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] drm: Allow platform devices to register as DRM devices

On Mon, Mar 15, 2010 at 10:56:02AM +1000, Dave Airlie wrote:
> On Tue, Mar 2, 2010 at 2:00 AM, Jordan Crouse <jcrouse@...eaurora.org> wrote:
> >
> > Allow platform devices without PCI resources to be DRM devices.
> >
> > Signed-off-by: Jordan Crouse <jcrouse@...eaurora.org>
> 
> This patch has a bunch of whitespace damage at least in my inbox and
> also in patchwork
> 
> Please also be careful with the places you add copyrights, you moved a
> bunch of code from drm_drv.c to drm_pci.c and added a copyright for
> Code Aurora in drm_pci.c? You can only assert copyright if you actually
> wrote the code, otherwise the patch contains your authorship details
> and who contributed the code. I'm guessing you might have copyright
> over one file in this that being drm_platform.c, the rest I'm less sure
> about.
> 
> I also wonder if we could/should separate the arm drm support out from
> this patch (i.e.  the __arm__ changes).
> 
Also note that pgprot_noncached() is a standard interface these days, so
there is no longer any reason to special case it. There's no reason for
the io prot mapping code turning in to the hell that was the fbmem.c
mmap.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/