linux-kernel - Re: [PATCH 1/1] infiniband: ulp/iser, fix error retval in iser_create_ib_conn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada634v9644.fsf@roland-alpha.cisco.com>
Date:	Tue, 16 Mar 2010 16:52:43 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Dan Carpenter <error27@...il.com>, linux-kernel@...r.kernel.org,
	jirislaby@...il.com, Or Gerlitz <ogerlitz@...taire.com>
Subject: Re: [PATCH 1/1] infiniband: ulp/iser, fix error retval in iser_create_ib_conn_res

 >  	ib_conn->login_buf = kmalloc(ISER_RX_LOGIN_SIZE, GFP_KERNEL);
 >  	if (!ib_conn->login_buf) {
 > -		goto alloc_err;
 >  		ret = -ENOMEM;
 > +		goto alloc_err;
 >  	}

This looks like a valid fix but it's the same part of the code that Dan
found more extensive bugs in.  Or, can I assume you'll sort this out and
make sure a final patch is sorted out?

Thanks,
  Roland
-- 
Roland Dreier  <rolandd@...co.com>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/