linux-kernel - Re: [PATCH v2] KVM: cleanup {kvm_vm_ioctl, kvm}_get_dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BA095B9.3010109@oss.ntt.co.jp>
Date:	Wed, 17 Mar 2010 17:41:29 +0900
From:	Takuya Yoshikawa <yoshikawa.takuya@....ntt.co.jp>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
CC:	Avi Kivity <avi@...hat.com>, KVM list <kvm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] KVM: cleanup {kvm_vm_ioctl, kvm}_get_dirty_log()

Xiao Guangrong wrote:
> 
> Takuya Yoshikawa wrote:
> 
>> Oh, for such a tiny comment.
> 
> Your comment is valuable although it's tiny :-)
> 
> 
>> What I said was just you may be able to use bitmap_empty() instead of
>>
>>> -    for (i = 0; !is_dirty && i < n/sizeof(long); i++)
>>> -        is_dirty = memslot->dirty_bitmap[i];
>> for x86's code too, if your patch for kvm_get_dirty_log() was correct.
> 
> While i look into x86's code, i found we can direct call kvm_get_dirty_log()
> in kvm_vm_ioctl_get_dirty_log() to remove some unnecessary code, this is a
> better cleanup way

Ah, probably checking the git log will explain you why it is like that!
Marcelo's work? IIRC.

> 
> Thanks,
> Xiao
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/