linux-kernel - Re: [PATCH] perf: x86: fix callgraphs of 32-bit processes on 64-bit kernels V3.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100317095456.GE17146@elte.hu>
Date:	Wed, 17 Mar 2010 10:54:56 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	T??r??k Edwin <edwintorok@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: x86: fix callgraphs of 32-bit processes on 64-bit
 kernels V3.


* T??r??k Edwin <edwintorok@...il.com> wrote:

> +#ifdef CONFIG_COMPAT
> +	if (test_thread_flag(TIF_IA32)) {
> +		perf_callchain_user32(regs, entry);
> +		return;
> +	}
> +#endif

You can push that test into perf_callchain_user32() and turn it into something 
like:

	if (perf_callchain_user32(regs, entry))
		return;

without the #ifdef here.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/