[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20100317141528.GB3823@infomag.iguana.be>
Date: Wed, 17 Mar 2010 15:15:28 +0100
From: Wim Van Sebroeck <wim@...ana.be>
To: Florian Fainelli <florian@...nwrt.org>
Cc: linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH v2 0/4] RDC321x southbridge and GPIO support
Hi Florian,
> Here are 4 patches relative to adding support for the RDC321x southbridge.
> This southbridge is present on all x86-based RDC321x System-on-a-Chip and
> provides access to GPIOs and Wathchdog. The watchdog driver is already merged.
>
> Samuel, this is rebased on top of your mfd-2.6 master branch after commit
> 522dba7 and I think the 4 patches should go via your tree to make sure the
> merge is consistent.
>
> Thank you.
>
> Florian Fainelli (4):
> x86: remove rdc321x_defs.h
> MFD: add support for the RDC321x southbridge
> GPIO: add support for RDC321x GPIO controller
> WATCHDOG: convert rdc321x_wdt to use southbridge accessors
Watchdog part is OK for me. So Acked-by me can be added.
Personally I don't like the fact that you remove the rdc321x_defs.h file as the first patch.
If someone bisects the kernel, he will get a broken driver between the first and the fourth patch.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists